chart

• ChartMacro.java, 18.8.0: the source defaults to inline when the macro has content and to xdom otherwise, params is split on ";" and ":" with no escaping, and the title is the only alt text of the image.
• PlotType.java, 18.8.0: the 12 accepted values of type.
• Help.Macros.Chart: the uses of the macro in XWiki Standard, all inline tables with params="range:B2-D5;series:columns".

C1: "Input data for the chart macro (e.g. for 'inline' source mode)" does not say what to type: a table in the syntax of the page, with a header row and a first column of labels, and which cells hold the data, see the range of params. "'inline' source mode" is a developer term. To reproduce: open the Edit Macro dialog from Quick Actions.

C2: optional, since the data can come from a table of another page with source="xdom".

C4: a plain text area, where the user has to type a table in wiki syntax, like |=|=X|=Y , from the WYSIWYG editor. A table editor, or editing the table in place next to the chart, could be used.

C6: first in the Optional parameters tab, and set by the most common example.

C1, minor: "The height of the generated chart image" does not give the unit, pixels, which the documentation states.

C3: the field preselects the declared default, 300. The most common example sets 240, a value specific to that example: the examples of the Help pages of XWiki Standard keep the default.

C4: a plain text field for a number of pixels.

C13: a number, typed int, with no declared range, while only a positive number up to the limit of 2048 pixels of xwiki.properties is accepted: height="0" or height="abc" is accepted by the dialog and fails at rendering with "Width (400) and height (0) cannot be <= 0", and height="5000" with "Maximum chart width or height exceeded (limit is: [2048]x[2048]).".

C1: the label "Params" is an abbreviation of the ID, and the description, "Additional parameters for the data source", gives neither the format, key:value pairs separated by ";", nor the keys, range and series for a table, document and table for another page, and the colors and display options. Nothing says that the range is needed for the documented table, see C3. To reproduce: open the Edit Macro dialog from Quick Actions.

C3: the field opens empty, which stands for the whole table, header row and label column included, and fails for the table of the most common example: {{chart type="pie"}} with that table renders "Invalid number: [].". The example needs range:B2-D5 , or range:B2-.. for the whole data, a value no field preselects.

C4: a free text field for several settings in a dedicated syntax, like the parameters of jira. A custom picker for this mini-syntax would be overkill, so the text field is OK, as long as the description explains the syntax, which it does not, see C1.

C7: the document and table keys are an alternative to the content, with source="xdom": only parameters can be part of a feature, see the Cross-macro findings.

C13: a list of key:value pairs, with no declared format: params="range:B2-D5;series:columns;noSuchKey:1" is accepted and ignored, and params="garbage" fails at rendering with "Invalid number: [].".

C1: "The string describing the type of input data source (e.g. xdom or inline)" uses developer terms, "string" and "xdom", the internal name of a table of another page, and does not say that an empty value picks inline when the macro has content and xdom otherwise. The "e.g." suggests other values while there are only two. To reproduce: open the Edit Macro dialog from Quick Actions.

C3: the field opens empty, which stands for inline when the macro has content, the value of the most common example, so the example renders, but the field does not show which value it stands for.

C4: a free text field, although the accepted values are inline and xdom: a select could be used. source="foo" is accepted and fails at rendering, see E2.

C7: xdom, with the document and table keys of params, is an alternative to the content: only parameters can be part of a feature, see the Cross-macro findings.

C13: the accepted values are a list rather than a format, so it is recorded N/A: the select of C4 would declare them.

C1: "The title of the chart (appears on top of the chart image)" says what it sets. It does not say that it is also the only text alternative of the image, see the notes of the macro.

C3: the field opens empty, for no title, a sensible default: the title is specific to each chart.

C1: the description, "The type of the chart (e.g. pie, line, area or bar)", says what it sets, and the field is labeled "Type". It lists 4 of the 12 accepted values, see C4.

C2: mandatory, while a default type, like bar, would work for the table of the most common example and for any table of the documentation: {{chart params="range:B2-D5"}} with that table would give a chart instead of the error "Property [type] mandatory". Because of it, Quick Actions opens the Edit Macro dialog, see L1.

C4: a free text field, although the accepted values are the 12 chart types, line, area, bar, stackedbar, bar3D, stackedbar3D, pie, line3D, xy_area, xy_line_and_shape, xy_line3D and xy_step: a select, ideally with a preview of each type, could be used. type="foo" and type="Pie" are accepted by the dialog and fail at rendering, see E2.

C13: the accepted values are a list rather than a format, so it is recorded N/A: the select of C4 would declare them.

C1, minor: "The width of the generated chart image" does not give the unit, pixels, which the documentation states.

C3: the field preselects the declared default, 400. The most common example sets 320, a value specific to that example: the examples of the Help pages of XWiki Standard keep the default.

C4: a plain text field for a number of pixels. The field is the last of the dialog, below the fold.

C13: a number, typed int, with no declared range, while only a positive number up to the limit of 2048 pixels of xwiki.properties is accepted: width="320px" or width="50%" is accepted by the dialog and fails at rendering with "Width (0) and height (300) cannot be <= 0", width="-5" with "Width (-5) and height (300) cannot be <= 0", and width="5000" with "Maximum chart width or height exceeded (limit is: [2048]x[2048]).".