attachmentSelector

C4, minor: a page picker that offers every page, where only pages holding an XClass are useful, and the XClass of the example, XWiki.XWikiUsers, is a page the user has to know.

C13: the page picker builds a valid reference, so the dialog does not need to reject a typed value.

C4: a plain text field for the name of a property of the chosen class, where a select of the properties of that class could be used. For example, typing "nosuchprop" is accepted and the macro displays nothing.

C13, minor: the name of a property declares no format, so the dialog accepts property="a b" and the macro displays nothing, with no message.

C4: a plain text field for the number of an object, where a number field could be used. For example, typing "abc" is accepted and the macro silently uses the first object.

C8: an object number is needed only on a page that carries several objects of the class, which the examples of XWiki Standard never do, and the parameter is not advanced.

C13, minor: object is a string with no declared range, so object="-3" and object="99" are accepted and display nothing.

C8: a styling hook that no example sets, not marked advanced.

C3: form is the declared default and the value that most XWiki Standard sheets use, the theme and skin sheets, so it is preselected. The most common example sets direct, like the user profile.

C4: a plain text field prefilled with "form" for a choice between the two values form and direct, where a select could be used. For example, typing "maybe" is accepted and behaves as form.

C6: the example sets it, and it switches between the two uses of the macro, but the dialog sorts the fields alphabetically and shows it below the fold, after the fields filter, height, link and object.

C1: the description ends with the unrendered text "Defaults to $services.localization.render('xe.attachmentSelector.selectFile')" in the dialog, in English, French and German, instead of the text of the default button, "Choose an attachment".

C8: the label of the button is changed now and then, and the parameter is not advanced.

C4: an attachment picker, which was not checked for the attachments it lists.

C1, minor: the description gives no example value and keeps an outdated remark, "to become a comma separated list of mimetypes when XWiki will use HTML5", so the user cannot tell whether to write "pdf" or ".pdf".

C3: empty means every file, which the description says, and no single value is used in most cases.

C4: a plain text field for a comma separated list of file extensions, where a field that offers the common file types could be used. For example, typing "pdf odt" or "_{pdf" is accepted.}

C6: the example sets it, but the dialog shows it below the fold.

C13, minor: the list of extensions declares no format, so the dialog accepts any text.

C3, minor: the checkbox opens unchecked, while the most common example and every use of XWiki Standard that shows an image set displayImage="true".

C1, minor: the description gives no unit, and the documentation says a length in pixels, so a user cannot tell whether "180px" or "50%" works.

C4: a plain text field for a number of pixels, where a number field could be used. For example, typing "abc" is accepted and output as width="abc".

C6: the example sets it, but the dialog shows it below the fold, last of the optional fields.

C13: the width declares no range, so width="-3" and width="0" are accepted and output as is.

C1, minor: the description gives no unit, like width.

C4: a plain text field for a number of pixels, where a number field could be used. For example, typing "abc" is accepted and output as height="abc".

C8, minor: set rarely, since the examples set the width only, and not advanced.

C13: the height declares no range, like width.

C8, minor: set now and then, only for an image, and not advanced. It comes first in the dialog, before the fields of the example.

C8, minor: used in one documented example, and not advanced.

C1: the description, "The target page name to save/list attachments from", is accurate: the gallery lists and uploads on that page, while the property stays on the current page, which only the documentation says.

C8: set rarely, and not advanced.

C8: asks for a history comment, set rarely, and not advanced.